-
Notifications
You must be signed in to change notification settings - Fork 11
Create migration guide #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for industrial-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration guide looks good to me, thanks. I wonder if we have any note on the component pages for the pane and drawer mentioning the deprecation as well?
- moved drawer markdowns to legacy - fixed links - added migration guide to sidebar - fixed wrong quotation marks - fixed grammar mistakes
Co-authored-by: tokyojen <[email protected]>
Standardized the capitalization of 'V4' throughout the migration guide for consistency.
Revised instructions for replacing basic and map navigation elements, recommending use of ix-application and related components. Removed legacy theme section and improved formatting for clarity.
Documented the change in ix-application-header height from 2.75rem (44px) to 3rem (48px) in the 4.0.0 migration guide.
Eliminated a redundant 'components/charts-overview/index' item from the Charts section in the sidebar configuration to prevent duplication.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new migration guide and a blog post for the V4.0.0 release. The changes are comprehensive and well-structured. My review focuses on improving the clarity, consistency, and correctness of the new documentation. I've pointed out a few areas for improvement, such as fixing a typo, resolving a 'TBD' placeholder, and standardizing link formats. Additionally, I've identified a duplication issue in the sidebar configuration that should be addressed.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Eliminated repeated 'Drawer' tab items under 'legacy/drawer/index' in the sidebar configuration to avoid redundancy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kathrinschalber Changes approved, I will add another commit on AG Grid migration guide
Added the new UX writing formatting guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments 😇
Refines language in the 2025-10-01 release blog and 4.0.0 migration guide for clarity and accuracy. Updates Angular peer dependency requirements, clarifies AG Grid Figma library changes, and improves instructions for button and elevation variant migrations.
Updated the release notes to specify compatibility with Angular 20 and up, instead of just Angular 20, to better reflect the supported versions.
Jira issue: IX-3140